StackmasterFix

StackmasterFix

Applicability Statement / Applicability Notice

Chinese: This module is a client patch for the third-party module JStack424-Stackmaster. It contains two independent fixes:

| Item | Content | Nature |

|---|---|---|

| A | When building menu Alt + left click (upstream called Quick Grab Materials) to pull a complete set of materials, the materials in the box are not deducted (equal to copying) | It is a bug (still exists on upstream 1.2.0) |

| B | Upstream 1.2.0's new "Remember the last directly used box" fallback: after you empty a box, press Alt + E (Quick Stack) elsewhere, the things you just took out will be stuffed back into the empty box as they are | This is not a bug, it is a feature intentionally made by upstream (see below) |

⚠️ Regarding item B: This is not a bug of the original module, it is just my personal preference switch

The changelog of upstream 1.2.0 clearly states that this is an intentionally added feature -

「Quick Stack remembers the last directly observed chest for each exact item type,

even after that chest reaches zero stock", the purpose is to facilitate "replenishment":

If you have a chest containing wood and you empty it, the wood will automatically return to that chest the next time you quickly stack.

I think "chests I empty should stay empty", so I use the DisableRememberedChests switch to turn it off.

This is just a personal habit and does not mean that upstream has done something wrong. If you think the upstream behavior is good, please do not use this patch.

Or set the switch to false to restore the upstream behavior as is.

• This bug in item A was reproduced and located in my environment where 30+ modules are installed and connected to a remote dedicated server as a guest machine.

The original mod author has nothing to do with these issues. If you have any questions, please come to me first, not the original author.

• The original module may not have this bug in item A in other environments, and the symptoms may also be caused by the specific combination of my unit;

Not guaranteed to work in your environment.

• This patch only does these two things:

A: Change the deduction from "read-only snapshot copy" to "real container" and force write back to ZDO after the transaction is successful;

B: Change the return value of the upstream "memory box" rollback table to an empty table so that the rollback will never be triggered.

No values ​​will be changed, no upstream memory archive data will be touched, and no new features will be added.

• This patch has not been approved or reviewed by the original author, nor does it advocate any conclusion that "the original module has bugs" (except for item A, for which I gave IL evidence)——

Overall it's just a workaround for my machine.

• If you have fixed item A after upstreaming, please upgrade the upstream module first and disable this patch;

If you like the behavior of the upstream B item, set DisableRememberedChests to false.

English: This is a client-side patch for the third-party mod JStack424-Stackmaster,

with two independent fixes:

• A｜Quick Grab Materials did not consume materials (Alt + left-click a build piece):

chests were never debited, i.e. item duplication.

• B｜Quick Stack put items back into a chest you just emptied: Stackmaster 1.2.0 introduced

"remember the last directly observed chest" as a fallback destination.

⚠️ B is NOT a bug in the original mod. The upstream 1.2.0 changelog states this behaviour is

intentional ("even after that chest reaches zero stock", to make restocking convenient).

This patch merely turns that feature off because I personally prefer an emptied chest to stay

empty. If you like the upstream behaviour, do not use this patch, or set

DisableRememberedChests = false to restore it exactly.

• The A bug was reproduced and diagnosed on my setup: a 30+ mod client connecting to a

remote dedicated server. The original mod's author is not responsible for any of this.

• The original mod may be perfectly fine in …